Re: [PATCH 2/2] gitweb: Show trailing slash when listing tree entry in tree listing

From: Jakub Narebski <jnareb@gmail.com>
Date: Oct 10, 2006, 20:31 UTC
Message-ID: <200610102231.37136.jnareb@gmail.com>
In-Reply-To: <7vvemsymdx.fsf@assigned-by-dhcp.cox.net>

Junio C Hamano wrote:

Show 19 quoted lines

> Luben Tuikov <ltuikov@yahoo.com> writes:
> 
> > Or,
> >    "Click on the 'blob' link to get the ... Click on the 'tree' link to
> >     get the ... Oh you didn't know what a 'tree' or 'blob' object is?
> >     A 'blob' is ... A 'tree' is ..."
> >
> > At which point the engineer has lost 90% of his interest.
> >
> > It even gets even worse for the obnoxious "tree" link next to each commit
> > in shortlog view:
> >    "The tree link is the the tree object which is part of a commit object.
> >     Oh you don't know the internals of a commit object?  A commit object
> >     binds a tree object and a (parent) commit object, but blah, blah, blah..."
> 
> Isn't that a simple "labelling" question?  I do not think
> anybody minds to show clickable string "contents" (instead of
> "blob" or "tree") at the places you mention above and if we did
> so everybody would be happy, right?

Not, IMHO it is not a good idea. Clicking on file name leads to it contents, but it is not obvoius what kind of view is it. "blob" link leads to blob view, "tree" link leads to tree view, which are known what they mean to any git user.

-- 
Jakub Narebski
Poland