Re: [PATCH 2/2] gitweb: Show trailing slash when listing tree entry in tree listing
- From
- Luben Tuikov <ltuikov@yahoo.com>
- Date
- Oct 10, 2006, 20:52 UTC
- Message-ID
- <20061010205238.33892.qmail@web31803.mail.mud.yahoo.com>
- In-Reply-To
- <7vvemsymdx.fsf@assigned-by-dhcp.cox.net>
--- Junio C Hamano <junkio@cox.net> wrote:
Show 16 quoted lines
> Luben Tuikov <ltuikov@yahoo.com> writes: > > > Or, > > "Click on the 'blob' link to get the ... Click on the 'tree' link to > > get the ... Oh you didn't know what a 'tree' or 'blob' object is? > > A 'blob' is ... A 'tree' is ..." > > > > At which point the engineer has lost 90% of his interest. > > > > It even gets even worse for the obnoxious "tree" link next to each commit > > in shortlog view: > > "The tree link is the the tree object which is part of a commit object. > > Oh you don't know the internals of a commit object? A commit object > > binds a tree object and a (parent) commit object, but blah, blah, blah..." > > Isn't that a simple "labelling" question? I do not think
Not quite. You have to explain to the engineer that the "tree" link next to each "comit title" "shows" the project _at the state of that commit_. Which is the WORST PR for git and gitweb. Why?
Because now you have to explain internals of git and gitweb.
Instead of letting the engineer click on the commit to see the commit and then the commit provides a _context_ where "tree" makes much more intuitive sense.
OTOH, if one is an expert in git, then they have no problem getting to the information: commit->tree.
> anybody minds to show clickable string "contents" (instead of > "blob" or "tree") at the places you mention above and if we did
Well, "contents" of a commit is a tricky thing. This is why I don't like the "tree" link next to each commit in shortlog, but didn't mention anything when the patch was posted a couple of days ago.
It is just an unnecessary "fast forward interpretation" of commit.
> so everybody would be happy, right?
I don't know anymore.
Luben P.S. Notice how there is a "snapshot" link on each line of shortlog, but there is no "snapshot" link in the nav bar of a=commit. The "snapshot" link is next to "tree" down in the commit data. There is also a "tree" link which is also in the navbar, but "shortlog" is missing.