Re: [PATCH] gitweb: Do not print "log" and "shortlog" redundantly in commit view

From: Petr Baudis <pasky@suse.cz>
Date: Oct 7, 2006, 14:17 UTC
Message-ID: <20061007141721.GC20017@pasky.or.cz>
In-Reply-To: <200610071605.23277.jnareb@gmail.com>

Dear diary, on Sat, Oct 07, 2006 at 04:05:22PM CEST, I got a letter where Jakub Narebski <jnareb@gmail.com> said that...

Show 15 quoted lines

> Petr Baudis wrote:
> > Then it will be impossible to get snapshot of any subtree (apart of
> > manually constructing the URL). Hmm, and it's a bug that we don't show
> > the snapshot link when listing tree entry in tree listing, I thought
> > we did in the past...?
> > 
> > I think we should make it more clear what each of the bars concerns,
> > perhaps doing some more significant redesign:
> > 
> > [summary] is redundant, you have this big project name link in the top
> > left corner. All the other navbar options concern commit, so why not
> > merge it with the awkward commit box below the navbars?
> > 
> > All the "views bar" options concern the currently selected object, so
> > why not merge it with the object "descriptor", that is the path?

To make the idea more graphic:

Commit title master             shortlog | log | commit | commitdiff | tree

[project.git] / subdir / filename              blame | history | raw | HEAD

Or perhaps first the navigation, then the title.

> > Patches will follow up.

I have decided to reprioritize and do other stuff now. I will get back to it sometime later if noone does it first.

Show 5 quoted lines

> I think that "summary" has it's place rather in the bottom navigation 
> bar, in the "views bar", because it is related to current object not 
> current commit (the "tree" entry in top navigation bar, "actions bar", 
> is somewhat misleading because it actually is the tree of the commit, 
> not any tree).

It's not related to current object any more than to the current commit and is really out-of-place in both bars. It's related only to the current project.

We _do_ have a project-global bar at each page. It's the footer, containing the description and RSS link. What about stashing it there? ;-)

-- 
				Petr "Pasky" Baudis
Stuff: http://pasky.or.cz/
#!/bin/perl -sp0777i<X+d*lMLa^*lN%0]dsXx++lMlN/dsM0<j]dsj
$/=unpack('H*',$_);$_=`echo 16dio\U$k"SK$/SM$n\EsN0p[lN*1
lK[d2%Sa2/d0$^Ixp"|dc`;s/\W//g;$_=pack('H*',/((..)*)$/)