Re: [PATCH 2/2] gitweb: Show trailing slash when listing tree entry in tree listing

From: Luben Tuikov <ltuikov@yahoo.com>
Date: Oct 7, 2006, 18:44 UTC
Message-ID: <20061007184418.64881.qmail@web31812.mail.mud.yahoo.com>
In-Reply-To: <20061007141043.16912.73982.stgit@rover>

--- Petr Baudis <pasky@suse.cz> wrote:

> Signed-off-by: Petr Baudis <pasky@suse.cz>
> ---

First, this is a Unixism, and would confuse other OS users.
Second, "/" is after all _not part of the name_ of the tree/directory,
but part of the filesystem's path separator, let's not export it
to users of other OS's.
Third, directories/trees are already clearly 
  1) underlined, and
  2) differently colored,
which makes it overly obvious what it what.

In fact, my eyes only scan for the different color/underlined entries when I'm searching for a directory in tree view. I don't even look at the left-most column.

NACK!

   Luben

Show 22 quoted lines

> 
>  gitweb/gitweb.perl |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/gitweb/gitweb.perl b/gitweb/gitweb.perl
> index 096a01b..c3d09a2 100755
> --- a/gitweb/gitweb.perl
> +++ b/gitweb/gitweb.perl
> @@ -1791,7 +1791,7 @@ sub git_print_tree_entry {
>  		print "<td class=\"list\">";
>  		print $cgi->a({-href => href(action=>"tree", hash=>$t->{'hash'},
>  		                             file_name=>"$basedir$t->{'name'}", %base_key)},
> -		              esc_html($t->{'name'}));
> +		              esc_html($t->{'name'} . '/'));
>  		print "</td>\n";
>  		print "<td class=\"link\">";
>  		if (defined $hash_base) {
> -
> To unsubscribe from this list: send the line "unsubscribe git" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
>