Re: [PATCH] gitweb: Do not print "log" and "shortlog" redundantly in commit view

From: Jakub Narebski <jnareb@gmail.com>
Date: Oct 7, 2006, 14:05 UTC
Message-ID: <200610071605.23277.jnareb@gmail.com>
In-Reply-To: <20061007132457.GB20017@pasky.or.cz>

Petr Baudis wrote:

Show 16 quoted lines

> Then it will be impossible to get snapshot of any subtree (apart of
> manually constructing the URL). Hmm, and it's a bug that we don't show
> the snapshot link when listing tree entry in tree listing, I thought
> we did in the past...?
> 
> I think we should make it more clear what each of the bars concerns,
> perhaps doing some more significant redesign:
> 
> [summary] is redundant, you have this big project name link in the top
> left corner. All the other navbar options concern commit, so why not
> merge it with the awkward commit box below the navbars?
> 
> All the "views bar" options concern the currently selected object, so
> why not merge it with the object "descriptor", that is the path?
> 
> Patches will follow up.

I think that "summary" has it's place rather in the bottom navigation 
bar, in the "views bar", because it is related to current object not 
current commit (the "tree" entry in top navigation bar, "actions bar", 
is somewhat misleading because it actually is the tree of the commit, 
not any tree). But the refactoring of "views" navigation bar is a good 
idea. For tree it would be
	tree | _history_ | _blame_ | _snapshot_
(when there would be tree_blame back - there was short experiment, patch 
on git list; snapshot of course only when enabled).

I'd leave "summary" view, because the uther, especially with custome $home_link_str might be not obvous that it leads to summary view.

-- 
Jakub Narebski
Poland