git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH 06/28] validate_packed_ref_cache(): take a `packed_ref_store *` parameter

From
Michael Haggerty <mhagger@alum.mit.edu>
Date
Jun 15, 2017, 14:47 UTC
Message-ID
<ee2a855dd49a88a8545fcb1654782a407ee4af8a.1497534157.git.mhagger@alum.mit.edu>
In-Reply-To
<cover.1497534157.git.mhagger@alum.mit.edu>
It only cares about the packed-refs part of the reference store.
Signed-off-by: Michael Haggerty <mhagger@alum.mit.edu>
---
 refs/files-backend.c | 13 ++++++-------
 1 file changed, 6 insertions(+), 7 deletions(-)
diff --git a/refs/files-backend.c b/refs/files-backend.c
index 2b0db60b2b..f061506bf0 100644
--- a/refs/files-backend.c
+++ b/refs/files-backend.c
@@ -396,12 +396,11 @@ static void files_ref_path(struct files_ref_store *refs,
  * Check that the packed refs cache (if any) still reflects the
  * contents of the file. If not, clear the cache.
  */
-static void validate_packed_ref_cache(struct files_ref_store *refs)
+static void validate_packed_ref_cache(struct packed_ref_store *refs)
 {
-	if (refs->packed_ref_store->cache &&
-	    !stat_validity_check(&refs->packed_ref_store->cache->validity,
-				 refs->packed_ref_store->path))
-		clear_packed_ref_cache(refs->packed_ref_store);
+	if (refs->cache &&
+	    !stat_validity_check(&refs->cache->validity, refs->path))
+		clear_packed_ref_cache(refs);
 }
 
 /*
@@ -417,7 +416,7 @@ static struct packed_ref_cache *get_packed_ref_cache(struct files_ref_store *ref
 	const char *packed_refs_file = refs->packed_ref_store->path;
 
 	if (!is_lock_file_locked(&refs->packed_ref_store->lock))
-		validate_packed_ref_cache(refs);
+		validate_packed_ref_cache(refs->packed_ref_store);
 
 	if (!refs->packed_ref_store->cache)
 		refs->packed_ref_store->cache = read_packed_refs(packed_refs_file);
@@ -1364,7 +1363,7 @@ static int lock_packed_refs(struct files_ref_store *refs, int flags)
 	 * cache is still valid. We've just locked the file, but it
 	 * might have changed the moment *before* we locked it.
 	 */
-	validate_packed_ref_cache(refs);
+	validate_packed_ref_cache(refs->packed_ref_store);
 
 	packed_ref_cache = get_packed_ref_cache(refs);
 	/* Increment the reference count to prevent it from being freed: */
-- 
2.11.0
Previous: Michael HaggertyNext: Michael Haggerty
Message 45 of 52 in “Create a reference backend for packed refs”
  1. 00/28 Create a reference backend for packed refsMichael Haggerty, Jun 15, 2017
  2. 01/28 add_packed_ref(): teach function to overwrite existing refsMichael Haggerty, Jun 15, 2017
  3. 03/28 packed_ref_store: move `packed_refs_path` hereMichael Haggerty, Jun 15, 2017
  4. Stefan BellerJun 16, 2017
  5. 04/28 packed_ref_store: move `packed_refs_lock` member hereMichael Haggerty, Jun 15, 2017
  6. Stefan BellerJun 16, 2017
  7. Michael HaggertyJun 16, 2017
  8. Stefan BellerJun 16, 2017
  9. 07/28 get_packed_ref_cache(): take a `packed_ref_store *` parameterMichael Haggerty, Jun 15, 2017
  10. 08/28 get_packed_refs(): take a `packed_ref_store *` parameterMichael Haggerty, Jun 15, 2017
  11. 09/28 add_packed_ref(): take a `packed_ref_store *` parameterMichael Haggerty, Jun 15, 2017
  12. 10/28 lock_packed_refs(): take a `packed_ref_store *` parameterMichael Haggerty, Jun 15, 2017
  13. 11/28 commit_packed_refs(): take a `packed_ref_store *` parameterMichael Haggerty, Jun 15, 2017
  14. 13/28 get_packed_ref(): take a `packed_ref_store *` parameterMichael Haggerty, Jun 15, 2017
  15. 14/28 repack_without_refs(): take a `packed_ref_store *` parameterMichael Haggerty, Jun 15, 2017
  16. 15/28 packed_peel_ref(): new function, extracted from `files_peel_ref()`Michael Haggerty, Jun 15, 2017
  17. Stefan BellerJun 16, 2017
  18. Michael HaggertyJun 16, 2017
  19. Stefan BellerJun 16, 2017
  20. 16/28 packed_ref_store: support iterationMichael Haggerty, Jun 15, 2017
  21. 17/28 packed_read_raw_ref(): new function, replacing `resolve_packed_ref()`Michael Haggerty, Jun 15, 2017
  22. 19/28 packed_ref_store: make class into a subclass of `ref_store`Michael Haggerty, Jun 15, 2017
  23. 20/28 commit_packed_refs(): report errors rather than dyingMichael Haggerty, Jun 15, 2017
  24. 21/28 commit_packed_refs(): use a staging file separate from the lockfileMichael Haggerty, Jun 15, 2017
  25. Junio C HamanoJul 20, 2017
  26. Jonathan NiederJul 20, 2017
  27. Junio C HamanoJul 21, 2017
  28. Junio C HamanoJul 21, 2017
  29. Jeff KingJul 24, 2017
  30. Jonathan NiederJul 24, 2017
  31. Jeff KingJul 24, 2017
  32. Junio C HamanoJul 24, 2017
  33. Michael HaggertyJul 26, 2017
  34. 22/28 packed_refs_lock(): function renamed from lock_packed_refs()Michael Haggerty, Jun 15, 2017
  35. 18/28 packed-backend: new module for handling packed referencesMichael Haggerty, Jun 15, 2017
  36. Stefan BellerJun 16, 2017
  37. 24/28 packed_refs_unlock(), packed_refs_is_locked(): new functionsMichael Haggerty, Jun 15, 2017
  38. 26/28 commit_packed_refs(): remove call to `packed_refs_unlock()`Michael Haggerty, Jun 15, 2017
  39. 28/28 read_packed_refs(): die if `packed-refs` contains bogus dataMichael Haggerty, Jun 15, 2017
  40. 23/28 packed_refs_lock(): report errors via a `struct strbuf *err`Michael Haggerty, Jun 15, 2017
  41. 27/28 repack_without_refs(): don't lock or unlock the packed refsMichael Haggerty, Jun 15, 2017
  42. 25/28 clear_packed_ref_cache(): don't protest if the lock is heldMichael Haggerty, Jun 15, 2017
  43. 12/28 rollback_packed_refs(): take a `packed_ref_store *` parameterMichael Haggerty, Jun 15, 2017
  44. 02/28 packed_ref_store: new structMichael Haggerty, Jun 15, 2017
  45. 06/28 validate_packed_ref_cache(): take a `packed_ref_store *` parameterMichael Haggerty, Jun 15, 2017
  46. 05/28 clear_packed_ref_cache(): take a `packed_ref_store *` parameterMichael Haggerty, Jun 15, 2017
  47. Junio C HamanoJun 19, 2017
  48. Junio C HamanoJun 19, 2017
  49. Jeff KingJun 19, 2017
  50. Jeff KingJun 19, 2017
  51. Michael HaggertyJun 22, 2017
  52. Junio C HamanoJun 22, 2017

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.