[PATCH v3 1/2] ci: drop quarantine removal for macos perforce binaries
- From
Harald Nordgren via GitGitGadget <gitgitgadget@gmail.com>
- Date
- Oct 26, 2026, 09:54 UTC
- Message-ID
- <e85ce85d921f5c847c4a370a5c56c98f2f20cee2.1793008465.git.gitgitgadget@gmail.com>
- In-Reply-To
- <pull.2403.v3.git.git.1793008465.gitgitgadget@gmail.com>
From: Harald Nordgren <haraldnordgren@gmail.com>
A file downloaded with wget never gets com.apple.quarantine set, only Safari, Finder, and AirDrop apply that attribute through the LaunchServices quarantine API.
5ed9fc3fc8 (ci: prevent `perforce` from being quarantined, 2020-02-27) added this to stop p4d -V from hanging on a GUI confirmation dialog that never comes on a CI box, back when perforce was installed via Homebrew's --no-quarantine cask flag. When 49af448197 (ci: reintroduce prevention from perforce being quarantined in macOS, 2022-05-12) replaced that with a plain wget and tar download, it kept an xattr -d call as a precaution while noting that call already does nothing on GitHub Actions. It has been a silent no-op ever since.
Signed-off-by: Harald Nordgren <haraldnordgren@gmail.com> --- ci/install-dependencies.sh | 1 - 1 file changed, 1 deletion(-)
diff --git a/ci/install-dependencies.sh b/ci/install-dependencies.sh index d57dce5663..203e8401cf 100755 --- a/ci/install-dependencies.sh +++ b/ci/install-dependencies.sh @@ -122,7 +122,6 @@ macos-*) mkdir -p "$CUSTOM_PATH" wget -q "$P4WHENCE/bin.macosx12arm64/helix-core-server.tgz" && tar -xf helix-core-server.tgz -C "$CUSTOM_PATH" p4 p4d && - sudo xattr -d com.apple.quarantine "$CUSTOM_PATH/p4" "$CUSTOM_PATH/p4d" 2>/dev/null || true rm helix-core-server.tgz case "$jobname" in
-- gitgitgadget