git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH v2] ci: fail the build if perforce, git-lfs, or JGit fail to install

From
Harald Nordgren <haraldnordgren@gmail.com>
Date
Oct 26, 2026, 08:13 UTC
Message-ID
<CAHwyqnUwSv4Pa1GT3rikOcho2MVYA7sRV7RpP_KXcSa-2dWrWQ@mail.gmail.com>
In-Reply-To
<at8KIQPtBHXyLPyY@pks.im>
On Mon, Oct 26, 2026 at 10:07 AM Patrick Steinhardt <ps@pks.im> wrote:
Show 25 quoted lines
>
> On Mon, Oct 26, 2026 at 09:38:10AM +0200, Harald Nordgren wrote:
> > > > @@ -121,9 +133,16 @@ macos-*)
> > > >
> > > >       mkdir -p "$CUSTOM_PATH"
> > > >       wget -q "$P4WHENCE/bin.macosx12arm64/helix-core-server.tgz" &&
> > > > -     tar -xf helix-core-server.tgz -C "$CUSTOM_PATH" p4 p4d &&
> > > > +     tar -xf helix-core-server.tgz -C "$CUSTOM_PATH" p4 p4d || {
> > > > +             echo >&2 "error: could not install perforce"
> > > > +             exit 1
> > > > +     }
> > > >       sudo xattr -d com.apple.quarantine "$CUSTOM_PATH/p4" "$CUSTOM_PATH/p4d" 2>/dev/null || true
> > >
> > > This line is a bit curious, it makes me wonder whether we want to
> > > tighten it as well now. Any reason why we wouldn't?
> >
> > I asked Claud about it and it said this, does it make sense?
> >
> > 'wget/curl never set com.apple.quarantine in the first place (only
> > Safari/Finder/AirDrop do, via the LaunchServices quarantine API), so
> > xattr -d on these files always fails with "No such xattr." Tightening
> > it to fatal would break every macOS build, every time.'
>
> Well, if so we should be able to remove it without any detriment, right?
> Maybe that could be part of a preparatory patch.

Best way to find out is just to do it, I guess. I can include it in v3 and then you can trigger a build on GitLab with it? I'll let GitHub CI pass before pushing anything out.

Harald
Previous: Patrick SteinhardtNext: Patrick Steinhardt
Message 15 of 29 in “ci: only warn about perforce/git-lfs/JGit on platforms that need them”
  1. ci: only warn about perforce/git-lfs/JGit on platforms that need themHarald Nordgren via GitGitGadget, Sep 12, 2026
  2. Junio C HamanoSep 25, 2026
  3. Patrick SteinhardtSep 28, 2026
  4. Harald NordgrenSep 28, 2026
  5. ci: fail the build if perforce, git-lfs, or JGit fail to installHarald Nordgren via GitGitGadget, Oct 23, 2026
  6. Junio C HamanoOct 23, 2026
  7. Harald NordgrenOct 23, 2026
  8. Junio C HamanoOct 23, 2026
  9. Patrick SteinhardtOct 26, 2026
  10. Harald NordgrenOct 26, 2026
  11. Harald NordgrenOct 26, 2026
  12. Patrick SteinhardtOct 26, 2026
  13. Harald NordgrenOct 26, 2026
  14. Patrick SteinhardtOct 26, 2026
  15. Harald NordgrenOct 26, 2026
  16. Patrick SteinhardtOct 26, 2026
  17. 0/2 ci: fail the build if perforce, git-lfs or JGit fail to installHarald Nordgren via GitGitGadget, Oct 26, 2026
  18. 1/2 ci: drop quarantine removal for macos perforce binariesHarald Nordgren via GitGitGadget, Oct 26, 2026
  19. Patrick SteinhardtOct 26, 2026
  20. Harald NordgrenOct 26, 2026
  21. Harald NordgrenOct 26, 2026
  22. Junio C HamanoOct 26, 2026
  23. 2/2 ci: fail the build if perforce, git-lfs, or JGit fail to installHarald Nordgren via GitGitGadget, Oct 26, 2026
  24. Patrick SteinhardtOct 26, 2026
  25. Harald NordgrenOct 26, 2026
  26. 0/2 ci: fail the build if perforce, git-lfs or JGit fail to installHarald Nordgren via GitGitGadget, Oct 27, 2026
  27. 1/2 ci: drop quarantine removal for macos perforce binariesHarald Nordgren via GitGitGadget, Oct 27, 2026
  28. 2/2 ci: fail the build if perforce, git-lfs, or JGit fail to installHarald Nordgren via GitGitGadget, Oct 27, 2026
  29. Patrick SteinhardtOct 27, 2026

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.