git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH v2] ci: fail the build if perforce, git-lfs, or JGit fail to install

From
Patrick Steinhardt <ps@pks.im>
Date
Oct 26, 2026, 07:13 UTC
Message-ID
<at79nEHLDrcoCgn_@pks.im>
In-Reply-To
<pull.2403.v2.git.git.1792774249888.gitgitgadget@gmail.com>
On Fri, Oct 23, 2026 at 04:50:49PM +0000, Harald Nordgren via GitGitGadget wrote:
Show 6 quoted lines
>     Changes in v2:
>     
>      * Perforce, git-lfs, and JGit install failures now fail the build
>        instead of being silently swallowed. Removed the presence checks and
>        warnings at the end of the script, dead code once install failure is
>        fatal.
Thanks for adapting!
Show 17 quoted lines
> diff --git a/ci/install-dependencies.sh b/ci/install-dependencies.sh
> index d57dce5663..dad35db78b 100755
> --- a/ci/install-dependencies.sh
> +++ b/ci/install-dependencies.sh
> @@ -95,21 +95,33 @@ ubuntu-*|i386/ubuntu-*|debian-*)
>  			"$P4WHENCE/bin.linux26x86_64/p4d" \
>  			"$P4WHENCE/bin.linux26x86_64/p4" &&
>  		chmod a+x "$CUSTOM_PATH/p4d" "$CUSTOM_PATH/p4" || {
> -			rm -f "$CUSTOM_PATH/p4"
> -			rm -f "$CUSTOM_PATH/p4d"
> +			echo >&2 "error: could not install perforce"
> +			exit 1
>  		}
> +		echo "$(tput setaf 6)Perforce Server Version$(tput sgr0)"
> +		p4d -V
> +		echo "$(tput setaf 6)Perforce Client Version$(tput sgr0)"
> +		p4 -V

Okay. I was wondering whether we'd even see these binaries or whether we'd have to `"${CUSTOM_PATH}"/p4d -V` instead. But `$CUSTOM_PATH` gets set up in "ci/lib.sh" already, so there's no need for that.

Show 11 quoted lines
>  		wget --quiet \
>  		     "$LFSWHENCE/git-lfs-linux-amd64-$LINUX_GIT_LFS_VERSION.tar.gz" &&
>  		tar -xzf "git-lfs-linux-amd64-$LINUX_GIT_LFS_VERSION.tar.gz" \
>  			-C "$CUSTOM_PATH" --strip-components=1 \
>  			"git-lfs-$LINUX_GIT_LFS_VERSION/git-lfs" &&
> -		rm "git-lfs-linux-amd64-$LINUX_GIT_LFS_VERSION.tar.gz" ||
> -		rm -f "$CUSTOM_PATH/git-lfs"
> +		rm "git-lfs-linux-amd64-$LINUX_GIT_LFS_VERSION.tar.gz" || {
> +			echo >&2 "error: could not install git-lfs"
> +			exit 1
> +		}

This could all be a bit less convoluted if we had `set -e` in "ci/lib.sh". But that certainly is outside the scope of this patch series, so meanwhile this looks good to me.

Show 10 quoted lines
> @@ -121,9 +133,16 @@ macos-*)
>  
>  	mkdir -p "$CUSTOM_PATH"
>  	wget -q "$P4WHENCE/bin.macosx12arm64/helix-core-server.tgz" &&
> -	tar -xf helix-core-server.tgz -C "$CUSTOM_PATH" p4 p4d &&
> +	tar -xf helix-core-server.tgz -C "$CUSTOM_PATH" p4 p4d || {
> +		echo >&2 "error: could not install perforce"
> +		exit 1
> +	}
>  	sudo xattr -d com.apple.quarantine "$CUSTOM_PATH/p4" "$CUSTOM_PATH/p4d" 2>/dev/null || true

This line is a bit curious, it makes me wonder whether we want to tighten it as well now. Any reason why we wouldn't?

>  	rm helix-core-server.tgz
Nit: this is inconsistent with git-lfs, where we also have the call to
rm as part of the condition chain.
Thanks!
Patrick
Previous: Junio C HamanoNext: Harald Nordgren
Message 9 of 29 in “ci: only warn about perforce/git-lfs/JGit on platforms that need them”
  1. ci: only warn about perforce/git-lfs/JGit on platforms that need themHarald Nordgren via GitGitGadget, Sep 12, 2026
  2. Junio C HamanoSep 25, 2026
  3. Patrick SteinhardtSep 28, 2026
  4. Harald NordgrenSep 28, 2026
  5. ci: fail the build if perforce, git-lfs, or JGit fail to installHarald Nordgren via GitGitGadget, Oct 23, 2026
  6. Junio C HamanoOct 23, 2026
  7. Harald NordgrenOct 23, 2026
  8. Junio C HamanoOct 23, 2026
  9. Patrick SteinhardtOct 26, 2026
  10. Harald NordgrenOct 26, 2026
  11. Harald NordgrenOct 26, 2026
  12. Patrick SteinhardtOct 26, 2026
  13. Harald NordgrenOct 26, 2026
  14. Patrick SteinhardtOct 26, 2026
  15. Harald NordgrenOct 26, 2026
  16. Patrick SteinhardtOct 26, 2026
  17. 0/2 ci: fail the build if perforce, git-lfs or JGit fail to installHarald Nordgren via GitGitGadget, Oct 26, 2026
  18. 1/2 ci: drop quarantine removal for macos perforce binariesHarald Nordgren via GitGitGadget, Oct 26, 2026
  19. Patrick SteinhardtOct 26, 2026
  20. Harald NordgrenOct 26, 2026
  21. Harald NordgrenOct 26, 2026
  22. Junio C HamanoOct 26, 2026
  23. 2/2 ci: fail the build if perforce, git-lfs, or JGit fail to installHarald Nordgren via GitGitGadget, Oct 26, 2026
  24. Patrick SteinhardtOct 26, 2026
  25. Harald NordgrenOct 26, 2026
  26. 0/2 ci: fail the build if perforce, git-lfs or JGit fail to installHarald Nordgren via GitGitGadget, Oct 27, 2026
  27. 1/2 ci: drop quarantine removal for macos perforce binariesHarald Nordgren via GitGitGadget, Oct 27, 2026
  28. 2/2 ci: fail the build if perforce, git-lfs, or JGit fail to installHarald Nordgren via GitGitGadget, Oct 27, 2026
  29. Patrick SteinhardtOct 27, 2026

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.