Re: [PATCH v3 2/2] ci: fail the build if perforce, git-lfs, or JGit fail to install
- From
Patrick Steinhardt <ps@pks.im>
- Date
- Oct 26, 2026, 11:08 UTC
- Message-ID
- <at80okuHpoUjUYpQ@pks.im>
- In-Reply-To
- <a57cfbb2a5c0f34e44595c3b688b18c760258685.1793008465.git.gitgitgadget@gmail.com>
On Mon, Oct 26, 2026 at 09:54:25AM +0000, Harald Nordgren via GitGitGadget wrote:
Show 17 quoted lines
> diff --git a/ci/install-dependencies.sh b/ci/install-dependencies.sh
> index 203e8401cf..7c3c6ad434 100755
> --- a/ci/install-dependencies.sh
> +++ b/ci/install-dependencies.sh
> @@ -94,22 +94,25 @@ ubuntu-*|i386/ubuntu-*|debian-*)
> wget --quiet --directory-prefix="$CUSTOM_PATH" \
> "$P4WHENCE/bin.linux26x86_64/p4d" \
> "$P4WHENCE/bin.linux26x86_64/p4" &&
> - chmod a+x "$CUSTOM_PATH/p4d" "$CUSTOM_PATH/p4" || {
> - rm -f "$CUSTOM_PATH/p4"
> - rm -f "$CUSTOM_PATH/p4d"
> - }
> + chmod a+x "$CUSTOM_PATH/p4d" "$CUSTOM_PATH/p4"
> + echo "$(tput setaf 6)Perforce Server Version$(tput sgr0)"
> + p4d -V
> + echo "$(tput setaf 6)Perforce Client Version$(tput sgr0)"
> + p4 -VIsn't the && chain completely useless now, both here and in the other cases? We let `set -e` do its thing, but we don't have any error handling for the whole block anymore after we dropped the error message.
Patrick