Re: [PATCH v2] ci: fail the build if perforce, git-lfs, or JGit fail to install
- From
Patrick Steinhardt <ps@pks.im>
- Date
- Oct 26, 2026, 08:06 UTC
- Message-ID
- <at8KIQPtBHXyLPyY@pks.im>
- In-Reply-To
- <CAHwyqnVVCp9ovsHDtc0pHYrFvpmdJq74gyx9yf3+ZWkL+d=CVA@mail.gmail.com>
On Mon, Oct 26, 2026 at 09:38:10AM +0200, Harald Nordgren wrote:
Show 20 quoted lines
> > > @@ -121,9 +133,16 @@ macos-*)
> > >
> > > mkdir -p "$CUSTOM_PATH"
> > > wget -q "$P4WHENCE/bin.macosx12arm64/helix-core-server.tgz" &&
> > > - tar -xf helix-core-server.tgz -C "$CUSTOM_PATH" p4 p4d &&
> > > + tar -xf helix-core-server.tgz -C "$CUSTOM_PATH" p4 p4d || {
> > > + echo >&2 "error: could not install perforce"
> > > + exit 1
> > > + }
> > > sudo xattr -d com.apple.quarantine "$CUSTOM_PATH/p4" "$CUSTOM_PATH/p4d" 2>/dev/null || true
> >
> > This line is a bit curious, it makes me wonder whether we want to
> > tighten it as well now. Any reason why we wouldn't?
>
> I asked Claud about it and it said this, does it make sense?
>
> 'wget/curl never set com.apple.quarantine in the first place (only
> Safari/Finder/AirDrop do, via the LaunchServices quarantine API), so
> xattr -d on these files always fails with "No such xattr." Tightening
> it to fatal would break every macOS build, every time.'Well, if so we should be able to remove it without any detriment, right? Maybe that could be part of a preparatory patch.
Patrick