Re: [PATCH v3 2/2] ci: fail the build if perforce, git-lfs, or JGit fail to install
- From
Harald Nordgren <haraldnordgren@gmail.com>
- Date
- Oct 26, 2026, 12:17 UTC
- Message-ID
- <CAHwyqnXk=Q=M6mZtF9QW4mjtuVtKt2zjqnMm85OeYPEVf1aBsQ@mail.gmail.com>
- In-Reply-To
- <at80okuHpoUjUYpQ@pks.im>
On Mon, Oct 26, 2026 at 1:08 PM Patrick Steinhardt <ps@pks.im> wrote:
Show 23 quoted lines
>
> On Mon, Oct 26, 2026 at 09:54:25AM +0000, Harald Nordgren via GitGitGadget wrote:
> > diff --git a/ci/install-dependencies.sh b/ci/install-dependencies.sh
> > index 203e8401cf..7c3c6ad434 100755
> > --- a/ci/install-dependencies.sh
> > +++ b/ci/install-dependencies.sh
> > @@ -94,22 +94,25 @@ ubuntu-*|i386/ubuntu-*|debian-*)
> > wget --quiet --directory-prefix="$CUSTOM_PATH" \
> > "$P4WHENCE/bin.linux26x86_64/p4d" \
> > "$P4WHENCE/bin.linux26x86_64/p4" &&
> > - chmod a+x "$CUSTOM_PATH/p4d" "$CUSTOM_PATH/p4" || {
> > - rm -f "$CUSTOM_PATH/p4"
> > - rm -f "$CUSTOM_PATH/p4d"
> > - }
> > + chmod a+x "$CUSTOM_PATH/p4d" "$CUSTOM_PATH/p4"
> > + echo "$(tput setaf 6)Perforce Server Version$(tput sgr0)"
> > + p4d -V
> > + echo "$(tput setaf 6)Perforce Client Version$(tput sgr0)"
> > + p4 -V
>
> Isn't the && chain completely useless now, both here and in the other
> cases? We let `set -e` do its thing, but we don't have any error
> handling for the whole block anymore after we dropped the error message.That's true! It would open up a lot of simplifications on the regular git tests if we could drop '&&' there too :)
Harald