Re: [PATCH v2] ci: fail the build if perforce, git-lfs, or JGit fail to install
Show 14 quoted lines
> > > > This could all be a bit less convoluted if we had `set -e` in
> > > > "ci/lib.sh". But that certainly is outside the scope of this patch
> > > > series, so meanwhile this looks good to me.
> > >
> > > Yeah, `set -e` is a gem of a command. Would be good to do later!
> >
> > But wait, we already have it in "ci/lib.sh"!
>
> Oh, I missed that!
>
> The question then becomes whether the error message is worth it. In case
> we see traces (`set -x`) I think it's somewhat pointless as you'd
> trivially see the last failing command anyway, so you'd know why it has
> failed.
> Anyway, this is all a bit of a tangent, I don't think there's a strong
> reason that this really must change.
I'll take a look at what I can do without ballooning this topic.
Harald