Re: [PATCH 1/4] gitweb: notes feature

From: Giuseppe Bilotta <giuseppe.bilotta@gmail.com>
Date: Feb 7, 2010, 20:11 UTC
Message-ID: <cb7bb73a1002071211n23a410f9icc3d4d29179c44ca@mail.gmail.com>
In-Reply-To: <7vock0evs8.fsf@alter.siamese.dyndns.org>

On Sun, Feb 7, 2010 at 7:38 PM, Junio C Hamano <gitster@pobox.com> wrote:

Show 5 quoted lines

>
> Notes are fundamenally metainformation about an _object_ [*1*] and are not
> metainformation about refs.  Since whatever magic notation to denote notes
> we choose wants to be applied to an arbitrary commit, it shouldn't be the
> at-brace syntax.

Makes sense. ^{note[:namespace]} is ok for me too btw, although maybe it looks a little off-base when compared with the tag indicator ^{} which works, in a sense, in the opposite direction.

Show 8 quoted lines

> [Footnote]
>
> *1* Yes, I am aware of movements to misuse notes to annotate anything
> after mapping it to a random SHA-1 value, but I think that is outside the
> scope of notes.  Our design decision should be based on supporting the
> primary use of annotating an object, and that might still keep such a use
> working, in which case that would be an added bonus.  But our design
> shouldn't be constrained by such a secondary use.

BTW, I still think that notes should be attachable to named refs (not SHA-1, thus) too.

-- 
Giuseppe "Oblomov" Bilotta