Re: [PATCH 1/4] gitweb: notes feature

From: Jakub Narebski <jnareb@gmail.com>
Date: Feb 7, 2010, 12:41 UTC
Message-ID: <201002071341.36440.jnareb@gmail.com>
In-Reply-To: <cb7bb73a1002070314t4f382d31k91423eac00a68715@mail.gmail.com>

On Sun, 7 Feb 2010, Giuseppe Bilotta wrote:

Show 13 quoted lines

> On Sun, Feb 7, 2010 at 2:48 AM, Johan Herland <johan@herland.net> wrote:
> > On Sunday 07 February 2010, Jakub Narebski wrote:
> >
> > > Also, perhaps "git notes show" should acquire --batch / --batch-check
> > > options, similar to git-cat-file's options of the same name?
> >
> > I'd much rather have support for ^{notes} (or similar) in the rev-parse
> > machinery, so that you could look up deadbeef's notes by passing
> > "deadbeef^{notes}" to 'git cat-file --batch'.
> 
> Maybe something like deadbeef@{notes[:namespace]}? The ability to
> embed the notes namespace to use in the call is very useful to be able
> to access all the notes with a single git call.

That is just bikeshedding, but I'd rather not use '@', which currently is used only for _reflog_ based revision specifiers: [<ref>]@{<date>}, [<ref>]@{<n>}, @{-<n>}, for notes which are not reflog based.

We can use

  echo <commit>^{notes} | git --notes-ref=<namespace> cat-file --batch

or perhaps

  echo <commit>^{notes:<namespace>} | git cat-file --batch

-- 
Jakub Narebski
Poland