Re: [PATCH 1/4] gitweb: notes feature

From: Giuseppe Bilotta <giuseppe.bilotta@gmail.com>
Date: Feb 5, 2010, 08:42 UTC
Message-ID: <cb7bb73a1002050042w20c8ca58hfac4283bee0a3676@mail.gmail.com>
In-Reply-To: <7vaavosdqq.fsf@alter.siamese.dyndns.org>

On Fri, Feb 5, 2010 at 1:55 AM, Junio C Hamano <gitster@pobox.com> wrote:

Show 9 quoted lines

> Jakub Narebski <jnareb@gmail.com> writes:
>
>> Still, 1 or 2 git commands per commit is a bit too much (with shortlog
>> displaying 100 commits per page)
>
> But who said you need to display notes for all commits by default?
>
> It could be a thing that you would get _on demand_, just like patch text
> or diffstat is given only on demand by going to the commitdiff page.

But while diffstat or patch text always make sense for _any_ commit, since you always have them; notes don't, in the sense that you might not have notes in most of the commits, and you might actually be looking for commits with notes.

At the very least, a view like shortlog should give an indicator that a commit has notes, and possible the namespaces where its notes are (e.g., you're only browsing for bugzilla notes).

Anyway, since git cat-file --batch, or --batch-check if we only want the indicator, (didn't know about these options, btw, thanks a bunch) means that we can get all the notes with a single extra call, what's the problem with displaying them? ;-)

-- 
Giuseppe "Oblomov" Bilotta