Re: [PATCH 1/4] gitweb: notes feature
- From
Junio C Hamano <gitster@pobox.com>
- Date
- Feb 4, 2010, 21:07 UTC
- Message-ID
- <7vwrys7lrm.fsf@alter.siamese.dyndns.org>
- In-Reply-To
- <201002041821.22864.jnareb@gmail.com>
Jakub Narebski <jnareb@gmail.com> writes:
Show 10 quoted lines
>> IOW, the code should be reading output from:
>>
>> GIT_NOTES_REF=$note_ref git show -s --format=%N $co{'id'}
>>
>> as the notes tree may not be storing notes in a flat one-level namespace
>> like you are assuming.
>
> First, for some mechanism of deployment (IIRC Apache's mod_perl) changes
> to environment variables from CGI script are not passed to invoked
> commands (I guess for security reasons).I do not believe you are unable to spawn
open $fd, '-|' 'sh', '-c', "GIT_NOTES_REF=$note_ref git show ..."
and read from it ;-).
For possible enhancement to make notes easier to use, see the other response.