Re: [PATCH 1/4] gitweb: notes feature
- From
Junio C Hamano <gitster@pobox.com>
- Date
- Feb 4, 2010, 16:46 UTC
- Message-ID
- <7v4olxhrti.fsf@alter.siamese.dyndns.org>
- In-Reply-To
- <7vpr4lhsfu.fsf@alter.siamese.dyndns.org>
Junio C Hamano <gitster@pobox.com> writes:
Show 8 quoted lines
> Giuseppe Bilotta <giuseppe.bilotta@gmail.com> writes:
>
>> + my %notes = () ;
>> + foreach my $note_ref (@note_refs) {
>> + my $obj = "$note_ref:$co{'id'}";
>
> I think this look-up is wrong (meaning: will stop working anytime in the
> future, and needs to be rewritten).IOW, the code should be reading output from:
GIT_NOTES_REF=$note_ref git show -s --format=%N $co{'id'}as the notes tree may not be storing notes in a flat one-level namespace like you are assuming.