Re: [PATCH 4/4] gitweb: show notes in commit(diff) view

From: Giuseppe Bilotta <giuseppe.bilotta@gmail.com>
Date: Feb 6, 2010, 16:13 UTC
Message-ID: <cb7bb73a1002060813l451ad669nf9ba2dc4643bbd58@mail.gmail.com>
In-Reply-To: <201002061534.02972.jnareb@gmail.com>

On Sat, Feb 6, 2010 at 3:34 PM, Jakub Narebski <jnareb@gmail.com> wrote:

Show 27 quoted lines

> Giuseppe Bilotta wrote:
>> 2010/2/6 Jakub Narebski <jnareb@gmail.com>:
>>> On Thu, 4 Jan 2010, Giuseppe Bilotta wrote:
>
> [...]
>>>>  # return all refs matching refs/notes/<globspecs> where the globspecs
>>>>  # are taken from the notes feature content.
>>>>  sub get_note_refs {
>>>> +     local $/ = "";
>>>> +
>>>
>>> Why it is needed here?  Why you want to use empty lines as terminator
>>> (which means reading whole paragraphs), while treating two or more
>>> consecutive empty lines as a single empty line (according to
>>> perlvar(1))?
>>>
>>> If you want to slurp whole file, this should be
>>>
>>>        local $/;
>>>
>>> or more explicit
>>>
>>>        local $/ = undef;
>>
>> Ah, sorry, for some reason I thought "" was the default.
>
> If you wanted to use default value, why set it at all?

Ach, sorry, forgot to reply to the first part of the question. It's used in a context where $/ is locally set to \0, so it needs to be reset.

-- 
Giuseppe "Oblomov" Bilotta