Re: [PATCH 1/4] gitweb: notes feature
- From
Giuseppe Bilotta <giuseppe.bilotta@gmail.com>
- Date
- Feb 7, 2010, 11:14 UTC
- Message-ID
- <cb7bb73a1002070314t4f382d31k91423eac00a68715@mail.gmail.com>
- In-Reply-To
- <201002070248.03855.johan@herland.net>
On Sun, Feb 7, 2010 at 2:48 AM, Johan Herland <johan@herland.net> wrote:
Show 8 quoted lines
> On Sunday 07 February 2010, Jakub Narebski wrote:
>
>> Also, perhaps "git notes show" should acquire --batch / --batch-check
>> options, similar to git-cat-file's options of the same name?
>
> I'd much rather have support for ^{notes} (or similar) in the rev-parse
> machinery, so that you could look up deadbeef's notes by passing
> "deadbeef^{notes}" to 'git cat-file --batch'.Maybe something like deadbeef@{notes[:namespace]}? The ability to embed the notes namespace to use in the call is very useful to be able to access all the notes with a single git call.
Show 12 quoted lines
>> > If we have a guarantee that the fan-outs follow a 2/[2/...] scheme, >> > the open2 approach might still be the best way to go, by just trying >> > not only namespace:xxxxx...xxx but also namespace:xx/xxxxx etc. >> > Horrible, but could still be coalesced in a single call. It mgiht also >> > be optimized to stop at the first successfull hit in a namespace. >> >> Nice trick! It seems like quite a good idea... but it would absolutely >> require using 'git cat-file --batch' rather than one git-show per try. > > Still, I'd still much rather use the notes.c code itself for doing this > since it should always be the fastest (not to mention future-proof) way of > making lookups in the notes tree.
I agree with you on this, btw. As I mentioned in the other message, these would just be workarounds for the current lack of support of these features in core. I'd probably try and have a go at the thing myself, too (i.e. first implement the core functionality, and then use it in gitweb), but I honestly don't feel confident enough to hack at git core.
-- Giuseppe "Oblomov" Bilotta