Re: [PATCHv8 1/7] gitweb: refactor author name insertion
2009/6/30 Jakub Narebski <jnareb@gmail.com>:
Show 16 quoted lines
> On Tue, 30 Jun 2009, Giuseppe Bilotta wrote:
>> +sub print_local_time {
>> + my %date = @_;
>> + if ($date{'hour_local'} < 6) {
>> + printf(" (<span class=\"atnight\">%02d:%02d</span> %s)",
>> + $date{'hour_local'}, $date{'minute_local'}, $date{'tz_local'});
>> + } else {
>> + printf(" (%02d:%02d %s)",
>> + $date{'hour_local'}, $date{'minute_local'}, $date{'tz_local'});
>> + }
>> +}
>
> Very nice refactoring.
>
> It could do with a comment describing its output, but it is not
> necessary, and IMHO not worth resend. We can always add it "in tree".Damn! I was sure I'd forget something ...
--
Giuseppe "Oblomov" Bilotta
Giuseppe Bilotta <giuseppe.bilotta@gmail.com>