Re: [PATCHv8 7/7] gitweb: add empty alt text to avatar img
- From
Jakub Narebski <jnareb@gmail.com>
- Date
- Jun 30, 2009, 20:29 UTC
- Message-ID
- <200906302229.50303.jnareb@gmail.com>
- In-Reply-To
- <1246312854-3365-8-git-send-email-giuseppe.bilotta@gmail.com>
On Tue, 30 Jun 2009, Giuseppe Bilotta wrote:
> The empty alt text optimizes screen estate in text-only browsers. > > Signed-off-by: Giuseppe Bilotta <giuseppe.bilotta@gmail.com>
I am not sure if such alt-text is a good idea from standards point of view. But the reasoning seems sound.
Acked-by: Jakub Narebski <jnareb@gmail.com>
Show 20 quoted lines
> ---
> gitweb/gitweb.perl | 1 +
> 1 files changed, 1 insertions(+), 0 deletions(-)
>
> diff --git a/gitweb/gitweb.perl b/gitweb/gitweb.perl
> index 862ea99..6a1b5b5 100755
> --- a/gitweb/gitweb.perl
> +++ b/gitweb/gitweb.perl
> @@ -1574,6 +1574,7 @@ sub git_get_avatar {
> "<img width=\"$size\" " .
> "class=\"avatar\" " .
> "src=\"$url\" " .
> + "alt=\"\" " .
> "/>" . $post_white;
> } else {
> return "";
> --
> 1.6.3.rc1.192.gdbfcb
>
> -- Jakub Narebski Poland