Re: [PATCHv8 6/7] gitweb: picon avatar provider
On Tue, 30 Jun 2009, Giuseppe Bilotta wrote:
> Simple implementation of picon that only relies on the indiana.edu
> database.
>
> Signed-off-by: Giuseppe Bilotta <giuseppe.bilotta@gmail.com>
Well written, and nice example how to add other avatar providers.
Acked-by: Jakub Narebski <jnareb@gmail.com>
[...]
Show 8 quoted lines
> - # Currently only the gravatar provider is available, and it
> - # depends on Digest::MD5. If an unknown provider is specified,
> - # the feature is disabled.
> + # Currently available providers are gravatar and picon.
> + # If an unknown provider is specified, the feature is disabled.
> +
> + # Gravatar depends on Digest::MD5.
> + # Picon currently relies on the indiana.edu database.
Show 5 quoted lines
> - # Currently only gravatars are supported, but other forms such as
> - # picons can be added by putting an else up here and defining $url
> + # Other providers can be added by extending the if chain, defining $url
> # as needed. If no variant puts something in $url, we assume avatars
> # are completely disabled/unavailable.
I see that you have updated comments too.
--
Jakub Narebski
Poland
Jakub Narebski <jnareb@gmail.com>