Re: [PATCHv8 1/7] gitweb: refactor author name insertion

From: Jakub Narebski <jnareb@gmail.com>
Date: Jun 30, 2009, 20:04 UTC
Message-ID: <200906302204.40876.jnareb@gmail.com>
In-Reply-To: <1246312854-3365-2-git-send-email-giuseppe.bilotta@gmail.com>

On Tue, 30 Jun 2009, Giuseppe Bilotta wrote:

Show 8 quoted lines

> Collect all author display code in appropriate functions, making it
> easier to extend these functions on the CGI side.
> 
> We also move some of the presentation code from hard-coded HTML to CSS,
> for easier customization.
> 
> A side effect of the refactoring is that now localtime is always
> displayed with the 'at night' warning.

It is a very nice side effect, I think.

> 
> Signed-off-by: Giuseppe Bilotta <giuseppe.bilotta@gmail.com>

Acked-by: Jakub Narebski <jnareb@gmail.com>

> ---
>  gitweb/gitweb.css  |    5 ++-
>  gitweb/gitweb.perl |   93 ++++++++++++++++++++++++++++++---------------------
>  2 files changed, 59 insertions(+), 39 deletions(-)

[...]

Show 10 quoted lines

> +sub print_local_time {
> +	my %date = @_;
> +	if ($date{'hour_local'} < 6) {
> +		printf(" (<span class=\"atnight\">%02d:%02d</span> %s)",
> +			$date{'hour_local'}, $date{'minute_local'}, $date{'tz_local'});
> +	} else {
> +		printf(" (%02d:%02d %s)",
> +			$date{'hour_local'}, $date{'minute_local'}, $date{'tz_local'});
> +	}
> +}

Very nice refactoring.

It could do with a comment describing its output, but it is not necessary, and IMHO not worth resend. We can always add it "in tree".

-- 
Jakub Narebski
Poland