Re: [PATCHv8 1/7] gitweb: refactor author name insertion

From: Jakub Narebski <jnareb@gmail.com>
Date: Jun 30, 2009, 21:08 UTC
Message-ID: <200906302308.58488.jnareb@gmail.com>
In-Reply-To: <cb7bb73a0906301323j32e1f8dam9ba185401b2d1e2f@mail.gmail.com>

On Tue, 30 Jun 2009, Giuseppe Bilotta wrote:

> 2009/6/30 Jakub Narebski <jnareb@gmail.com>:
>> On Tue, 30 Jun 2009, Giuseppe Bilotta wrote:

# prints time in local timezone, from result of parse_date # in the following format: " (HH:MM +/-tz_offset)" or " (%H:%M %z)" # with "atnight" warning when 0 <= hour_local < 6

or something like that.  Or just

# prints time in local timezone, from result of parse_date

Show 17 quoted lines

>>> +sub print_local_time {
>>> +     my %date = @_;
>>> +     if ($date{'hour_local'} < 6) {
>>> +             printf(" (<span class=\"atnight\">%02d:%02d</span> %s)",
>>> +                     $date{'hour_local'}, $date{'minute_local'}, $date{'tz_local'});
>>> +     } else {
>>> +             printf(" (%02d:%02d %s)",
>>> +                     $date{'hour_local'}, $date{'minute_local'}, $date{'tz_local'});
>>> +     }
>>> +}
>>
>> Very nice refactoring.
>>
>> It could do with a comment describing its output, but it is not
>> necessary, and IMHO not worth resend.  We can always add it "in tree".
> 
> Damn! I was sure I'd forget something ...

Don't worry. It can be always addd later, or Junio can just squash proposed comment (see above).

-- 
Jakub Narebski
Poland