git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCHv8 3/7] gitweb: use git_print_authorship_rows in 'tag' view too

From
Giuseppe Bilotta <giuseppe.bilotta@gmail.com>
Date
Jun 29, 2009, 22:00 UTC
Message-ID
<1246312854-3365-4-git-send-email-giuseppe.bilotta@gmail.com>
In-Reply-To
<1246312854-3365-3-git-send-email-giuseppe.bilotta@gmail.com>

parse_tag must be adapted to use the hash keys expected by git_print_authorship_rows. This is not a problem since git_tag is the only user of this sub.

Signed-off-by: Giuseppe Bilotta <giuseppe.bilotta@gmail.com>
---
 gitweb/gitweb.perl |   16 +++++++++-------
 1 files changed, 9 insertions(+), 7 deletions(-)
diff --git a/gitweb/gitweb.perl b/gitweb/gitweb.perl
index 9a8d775..a393ac6 100755
--- a/gitweb/gitweb.perl
+++ b/gitweb/gitweb.perl
@@ -2409,8 +2409,14 @@ sub parse_tag {
 			$tag{'name'} = $1;
 		} elsif ($line =~ m/^tagger (.*) ([0-9]+) (.*)$/) {
 			$tag{'author'} = $1;
-			$tag{'epoch'} = $2;
-			$tag{'tz'} = $3;
+			$tag{'author_epoch'} = $2;
+			$tag{'author_tz'} = $3;
+			if ($tag{'author'} =~ m/^([^<]+) <([^>]*)>/) {
+				$tag{'author_name'}  = $1;
+				$tag{'author_email'} = $2;
+			} else {
+				$tag{'author_name'} = $tag{'author'};
+			}
 		} elsif ($line =~ m/--BEGIN/) {
 			push @comment, $line;
 			last;
@@ -4620,11 +4626,7 @@ sub git_tag {
 	                                      $tag{'type'}) . "</td>\n" .
 	      "</tr>\n";
 	if (defined($tag{'author'})) {
-		my %ad = parse_date($tag{'epoch'}, $tag{'tz'});
-		print "<tr><td>author</td><td>" . esc_html($tag{'author'}) . "</td></tr>\n";
-		print "<tr><td></td><td>" . $ad{'rfc2822'} .
-			sprintf(" (%02d:%02d %s)", $ad{'hour_local'}, $ad{'minute_local'}, $ad{'tz_local'}) .
-			"</td></tr>\n";
+		git_print_authorship_rows(\%tag, 'author');
 	}
 	print "</table>\n\n" .
 	      "</div>\n";
-- 
1.6.3.rc1.192.gdbfcb
Previous: Giuseppe BilottaNext: Giuseppe Bilotta
Message 4 of 22 in “[PATCHv8 0/7] gitweb: avatar support”
  1. Giuseppe BilottaJun 29, 2009
  2. 1/7 gitweb: refactor author name insertionGiuseppe Bilotta, Jun 29, 2009
  3. 2/7 gitweb: uniform author info for commit and commitdiffGiuseppe Bilotta, Jun 29, 2009
  4. 3/7 gitweb: use git_print_authorship_rows in 'tag' view tooGiuseppe Bilotta, Jun 29, 2009
  5. 4/7 gitweb: (gr)avatar supportGiuseppe Bilotta, Jun 29, 2009
  6. 5/7 gitweb: gravatar url cacheGiuseppe Bilotta, Jun 29, 2009
  7. 6/7 gitweb: picon avatar providerGiuseppe Bilotta, Jun 29, 2009
  8. 7/7 gitweb: add empty alt text to avatar imgGiuseppe Bilotta, Jun 29, 2009
  9. Jakub NarebskiJun 30, 2009
  10. Jakub NarebskiJun 30, 2009
  11. Giuseppe BilottaJun 30, 2009
  12. Jakub NarebskiJun 30, 2009
  13. Junio C HamanoJun 30, 2009
  14. Giuseppe BilottaJun 30, 2009
  15. Jakub NarebskiJun 30, 2009
  16. Jakub NarebskiJun 30, 2009
  17. Jakub NarebskiJun 30, 2009
  18. Jakub NarebskiJun 30, 2009
  19. Giuseppe BilottaJun 30, 2009
  20. Jakub NarebskiJun 30, 2009
  21. Giuseppe BilottaJun 30, 2009
  22. Jakub NarebskiJul 1, 2009

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.