From: Giuseppe Bilotta <giuseppe.bilotta@gmail.com>
Date: Tue, 30 Jun 2009 20:23:34 GMT
Subject: Re: [PATCHv8 1/7] gitweb: refactor author name insertion
Message-ID: <cb7bb73a0906301323j32e1f8dam9ba185401b2d1e2f@mail.gmail.com>
In-Reply-To: <200906302204.40876.jnareb@gmail.com>

2009/6/30 Jakub Narebski <jnareb@gmail.com>:
> On Tue, 30 Jun 2009, Giuseppe Bilotta wrote:
>> +sub print_local_time {
>> +     my %date = @_;
>> +     if ($date{'hour_local'} < 6) {
>> +             printf(" (<span class=\"atnight\">%02d:%02d</span> %s)",
>> +                     $date{'hour_local'}, $date{'minute_local'}, $date{'tz_local'});
>> +     } else {
>> +             printf(" (%02d:%02d %s)",
>> +                     $date{'hour_local'}, $date{'minute_local'}, $date{'tz_local'});
>> +     }
>> +}
>
> Very nice refactoring.
>
> It could do with a comment describing its output, but it is not
> necessary, and IMHO not worth resend.  We can always add it "in tree".

Damn! I was sure I'd forget something ...

-- 
Giuseppe "Oblomov" Bilotta