Re: [PATCHv7 2/9] gitweb: uniform author info for commit and commitdiff
- From
Giuseppe Bilotta <giuseppe.bilotta@gmail.com>
- Date
- Jun 27, 2009, 22:33 UTC
- Message-ID
- <cb7bb73a0906271533g308fd42w82d11cd2658b1e99@mail.gmail.com>
- In-Reply-To
- <7vskhlikt7.fsf@alter.siamese.dyndns.org>
On Sat, Jun 27, 2009 at 8:38 PM, Junio C Hamano<gitster@pobox.com> wrote:
Show 20 quoted lines
> Jakub Narebski <jnareb@gmail.com> writes: > >> I would use: >> >> Switch from form similar to the one used by 'log' view >> >> A U Thor <email@example.com> [date time] >> >> to the form used in 'commit' view >> >> author A U Thor <email@example.com> >> date time >> committer C O Mitter <other.email@example.com> >> date time >> >> (i.e. use spaces and not tabs to align). But this is minor >> issue, not worth worrying about IMVHO. > > These extra blank lines make things much easier to read, and explicit > mention of switching from WHAT to WHAT ELSE is very much appreciated.
I updated the patch accordingly.
Show 7 quoted lines
>> On the other hand side IIRC 'commitdiff' uses short (one-line) >> authorship info because the main point is the diff, and multi-line >> author and commit info like the one used in 'commit' view takes >> a bit of vertical space. > > In general, we might want to make the committer information less prominent > than it currently is.
I've been thinking about this. A possible approach I considered could be to only show the commit _date_ by default (which could be interesting to see), and use some DHTML to show the committer on request. But as you mention, this is not the patchset to do this kind of work on 8-)
-- Giuseppe "Oblomov" Bilotta