Re: [PATCHv7 4/9] gitweb: right-align date cell in shortlog

From: Giuseppe Bilotta <giuseppe.bilotta@gmail.com>
Date: Jun 27, 2009, 22:27 UTC
Message-ID: <cb7bb73a0906271527g60a92daqd20e3c20e2d87842@mail.gmail.com>
In-Reply-To: <200906272028.05239.jnareb@gmail.com>

2009/6/27 Jakub Narebski <jnareb@gmail.com>:

Show 17 quoted lines

> On Sat, 27 June 2009, Giuseppe Bilotta wrote:
>
>> Signed-off-by: Giuseppe Bilotta <giuseppe.bilotta@gmail.com>
>
> I don't like it.  In my opinion it is less readable that way, especially
> if word wrapping gets involved:
>
>  5 hours |
>      ago |
>
>  5 hours |
>      ago |
>
>   5 days |
>      ago |
>
> It is IMVHO a bit ugly.

You might have a point there.

Show 7 quoted lines

> That aside this is *not complete*.  Take a look at 'summary' view.
> You have there 'date' column in 'shortlog' section aligned to the right,
> while in 'heads' and 'tags' section it is aligned to the left.  Add to
> that "Last Change" column in projects list view (which should probably
> be aligned to the left, even with this patch completed).
>
> NAK from me.  (Alternate stylesheet?  Just kidding...)

[...]

>
> On the other hand: it is short and simple.

And totally independent from the rest of the patchset. I'll move it to the top of the stack, so that the rest of the next iteration can be applied in batch as soon as it's ready.

-- 
Giuseppe "Oblomov" Bilotta