Re: [PATCHv7 1/9] gitweb: refactor author name insertion

From: Giuseppe Bilotta <giuseppe.bilotta@gmail.com>
Date: Jun 27, 2009, 15:26 UTC
Message-ID: <cb7bb73a0906270826y45f3f9f1lec720aa4dad2a237@mail.gmail.com>
In-Reply-To: <200906271624.52372.jnareb@gmail.com>

2009/6/27 Jakub Narebski <jnareb@gmail.com>:

> By the way, this "atnight" warning is duplicated in subroutine below
> git_print_authorship_rows(), but IMHO it is not something very important.
> It can be left for later.

I'll resend this patch, with this thing refactored too, and with the localtime fix.

Show 16 quoted lines

>> +     foreach my $who (@people) {
>> +             my %ad = parse_date($co->{$who . '_epoch'}, $co->{$who . '_tz'});
>
> Wouldn't
>
>  $co->{"${who}_epoch"}
>
> be simpler than
>
>  $co->{$who . '_epoch'}
>
> Also it is now %wd (%who_date) or just %date rather than
> %ad (%author_date) vs %cd (%committer_date).
>
>
> Both of those issues are very, very minor.

But I can tune them out 8-)

> Nice... although this set of diff chunks made me wonder why we
> use "10" for 'shortlog', "15, 3" for 'history, and "15, 5" for
> 'search' (grep).

I don't know about that. It might be worth considering unifying them.

> Thanks again for your diligent work on this patch series!

Thank you very much for your comments. I could clearly see the code improving significantly at each iteration. It's a great sastisfaction, even though it's quite some work.

-- 
Giuseppe "Oblomov" Bilotta