Re: [PATCHv7 9/9] gitweb: add alt text to avatar img
- From
Jakub Narebski <jnareb@gmail.com>
- Date
- Jun 28, 2009, 15:43 UTC
- Message-ID
- <200906281743.55871.jnareb@gmail.com>
- In-Reply-To
- <1246104305-15191-10-git-send-email-giuseppe.bilotta@gmail.com>
On Sat, 27 June 2009, Giuseppe Bilotta wrote:
> The alt text, set to the avatar provider (i.e. image type), is more > friendly than the img url in some text-only browsers.
Signoff?
Acked-by: Jakub Narebski <jnareb@gmail.com>
Show 17 quoted lines
> ---
> gitweb/gitweb.perl | 1 +
> 1 files changed, 1 insertions(+), 0 deletions(-)
>
> diff --git a/gitweb/gitweb.perl b/gitweb/gitweb.perl
> index e2638cb..dc6049a 100755
> --- a/gitweb/gitweb.perl
> +++ b/gitweb/gitweb.perl
> @@ -1578,6 +1578,7 @@ sub git_get_avatar {
> "<img width=\"$size\" " .
> "class=\"avatar\" " .
> "src=\"$url\" " .
> + "alt=\"$git_avatar\" " .
> "/>" . $post_white;
> } else {
> return "";
> -- Bit of bikeshedding: "alt=\"\" " (empty alt text) would also be a good solution. This way text browser which do not display images wouldn't take limited horizontal space for alt text of extraneous avatar image.
-- Jakub Narebski Poland