git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCHv7 2/9] gitweb: uniform author info for commit and commitdiff

From
Junio C Hamano <gitster@pobox.com>
Date
Jun 27, 2009, 18:38 UTC
Message-ID
<7vskhlikt7.fsf@alter.siamese.dyndns.org>
In-Reply-To
<200906271810.23119.jnareb@gmail.com>
Jakub Narebski <jnareb@gmail.com> writes:
Show 15 quoted lines
> I would use:
>
>   Switch from form similar to the one used by 'log' view
>
>   	A U Thor <email@example.com> [date time]
>
>   to the form used in 'commit' view
>
> 	author       A U Thor <email@example.com>
>   	 	     date time
>   	committer    C O Mitter <other.email@example.com>
>   	             date time
>
> (i.e. use spaces and not tabs to align).  But this is minor
> issue, not worth worrying about IMVHO.

These extra blank lines make things much easier to read, and explicit mention of switching from WHAT to WHAT ELSE is very much appreciated.

> On the other hand side IIRC 'commitdiff' uses short (one-line) 
> authorship info because the main point is the diff, and multi-line
> author and commit info like the one used in 'commit' view takes
> a bit of vertical space.

In general, we might want to make the committer information less prominent than it currently is.

When looking at a repository that is used like CVS, author and committer are always the same. When looking at a repository that is owned by a single integrator, the committer is a single person. The only time committer information for every commit would help is when viewing a repository of higher level integrator in a project that has subintegrators (e.g. Linus pulls from David who commits patches from others).

So at some point, it may not be a bad idea to introduce a per-repository option/feature to hide committer information from certain views to allocate more space for other information.

But certainly that shouldn't be a part of this topic.
Previous: Jakub NarebskiNext: Giuseppe Bilotta
Message 25 of 31 in “[PATCHv7 0/9] gitweb: avatar support”
  1. Giuseppe BilottaJun 27, 2009
  2. 1/9 gitweb: refactor author name insertionGiuseppe Bilotta, Jun 27, 2009
  3. 2/9 gitweb: uniform author info for commit and commitdiffGiuseppe Bilotta, Jun 27, 2009
  4. 3/9 gitweb: use git_print_authorship_rows in 'tag' view tooGiuseppe Bilotta, Jun 27, 2009
  5. 4/9 gitweb: right-align date cell in shortlogGiuseppe Bilotta, Jun 27, 2009
  6. 5/9 gitweb: (gr)avatar supportGiuseppe Bilotta, Jun 27, 2009
  7. 6/9 gitweb: gravatar url cacheGiuseppe Bilotta, Jun 27, 2009
  8. 7/9 gitweb: picon avatar providerGiuseppe Bilotta, Jun 27, 2009
  9. 8/9 gitweb: use picon for gravatar fallbackGiuseppe Bilotta, Jun 27, 2009
  10. 9/9 gitweb: add alt text to avatar imgGiuseppe Bilotta, Jun 27, 2009
  11. Jakub NarebskiJun 28, 2009
  12. Giuseppe BilottaJun 28, 2009
  13. Jakub NarebskiJun 28, 2009
  14. Jakub NarebskiJun 28, 2009
  15. Giuseppe BilottaJun 28, 2009
  16. Jakub NarebskiJun 27, 2009
  17. Jakub NarebskiJun 27, 2009
  18. Giuseppe BilottaJun 27, 2009
  19. Jakub NarebskiJun 27, 2009
  20. Jakub NarebskiJun 27, 2009
  21. Giuseppe BilottaJun 27, 2009
  22. Jakub NarebskiJun 27, 2009
  23. Giuseppe BilottaJun 27, 2009
  24. Jakub NarebskiJun 27, 2009
  25. Junio C HamanoJun 27, 2009
  26. Giuseppe BilottaJun 27, 2009
  27. Jakub NarebskiJun 27, 2009
  28. Giuseppe BilottaJun 27, 2009
  29. Giuseppe BilottaJun 27, 2009
  30. Jakub NarebskiJun 29, 2009
  31. Giuseppe BilottaJun 29, 2009

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.