git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCHv7 3/9] gitweb: use git_print_authorship_rows in 'tag' view too

From
Giuseppe Bilotta <giuseppe.bilotta@gmail.com>
Date
Jun 27, 2009, 22:24 UTC
Message-ID
<cb7bb73a0906271524k5681ce93pf79680eb728c516e@mail.gmail.com>
In-Reply-To
<200906272010.30754.jnareb@gmail.com>
2009/6/27 Jakub Narebski <jnareb@gmail.com>:
Show 9 quoted lines
> On Sat, 27 June 2009, Giuseppe Bilotta wrote:
>
>> parse_tag has to be adapted to use the hash keys expected by
>> git_print_authorship_rows, which is not a problem since git_tag
>> is the only user of this sub.
>
> Nitpick: I think that with s/has/had/ (past tense) and
> s/, which/. This/ (split paragraph into two sentences)
> it would read better.
I can do that.
> Sidenote: I wonder if it would be worth doing to factor out code dealing
> with extracting data from (parsing) author/committer/tagger object headers.
> Probably not worth it...
It might be worth it, but I'd say we can leave it to some other time ;-)
> I wonder why we used and use 'author' instead of 'tagger'...

The upside of using 'author' is that the tag can then be dealt with just like any other commit by the rest of the code, I think. I don't know if this benefit is actually used anywhere in the code.

-- 
Giuseppe "Oblomov" Bilotta
Previous: Jakub NarebskiNext: Jakub Narebski
Message 23 of 31 in “[PATCHv7 0/9] gitweb: avatar support”
  1. Giuseppe BilottaJun 27, 2009
  2. 1/9 gitweb: refactor author name insertionGiuseppe Bilotta, Jun 27, 2009
  3. 2/9 gitweb: uniform author info for commit and commitdiffGiuseppe Bilotta, Jun 27, 2009
  4. 3/9 gitweb: use git_print_authorship_rows in 'tag' view tooGiuseppe Bilotta, Jun 27, 2009
  5. 4/9 gitweb: right-align date cell in shortlogGiuseppe Bilotta, Jun 27, 2009
  6. 5/9 gitweb: (gr)avatar supportGiuseppe Bilotta, Jun 27, 2009
  7. 6/9 gitweb: gravatar url cacheGiuseppe Bilotta, Jun 27, 2009
  8. 7/9 gitweb: picon avatar providerGiuseppe Bilotta, Jun 27, 2009
  9. 8/9 gitweb: use picon for gravatar fallbackGiuseppe Bilotta, Jun 27, 2009
  10. 9/9 gitweb: add alt text to avatar imgGiuseppe Bilotta, Jun 27, 2009
  11. Jakub NarebskiJun 28, 2009
  12. Giuseppe BilottaJun 28, 2009
  13. Jakub NarebskiJun 28, 2009
  14. Jakub NarebskiJun 28, 2009
  15. Giuseppe BilottaJun 28, 2009
  16. Jakub NarebskiJun 27, 2009
  17. Jakub NarebskiJun 27, 2009
  18. Giuseppe BilottaJun 27, 2009
  19. Jakub NarebskiJun 27, 2009
  20. Jakub NarebskiJun 27, 2009
  21. Giuseppe BilottaJun 27, 2009
  22. Jakub NarebskiJun 27, 2009
  23. Giuseppe BilottaJun 27, 2009
  24. Jakub NarebskiJun 27, 2009
  25. Junio C HamanoJun 27, 2009
  26. Giuseppe BilottaJun 27, 2009
  27. Jakub NarebskiJun 27, 2009
  28. Giuseppe BilottaJun 27, 2009
  29. Giuseppe BilottaJun 27, 2009
  30. Jakub NarebskiJun 29, 2009
  31. Giuseppe BilottaJun 29, 2009

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.