Re: [PATCHv7 6/9] gitweb: gravatar url cache
- From
Jakub Narebski <jnareb@gmail.com>
- Date
- Jun 27, 2009, 22:15 UTC
- Message-ID
- <200906280015.31639.jnareb@gmail.com>
- In-Reply-To
- <1246104305-15191-7-git-send-email-giuseppe.bilotta@gmail.com>
On Sat, 27 June 2009, Giuseppe Bilotta wrote:
Show 5 quoted lines
> Views which contain many occurrences of the same email address (e.g. > shortlog view) benefit from not having to recalculate the MD5 of the > email address every time. > > Signed-off-by: Giuseppe Bilotta <giuseppe.bilotta@gmail.com>
Acked-by: Jakub Narebski <jnareb@gmail.com>
> ---
Here there are some very simple benchmarks of the effect of gravatar URL cache. I'm not sure if they should be put in commit message.
When running gitweb as a script $ time gitweb-run.sh "p=git.git;a=shortlog" >/dev/null I got the following results
| before | after ------------+-----------------|------------------ summary | 0.978s (0.964s) | 0.961s (0.940s) shortlog | 1.001s (0.980s) | 1.033s (1.008s)
which means the same results within the margin of error, (as seen when repeating benchmark the differences are within the range of fluctuations). Time is real (wallclock) time, in parentheses there is user + sys time.
When using ApacheBench 2.0.41-dev, with gitweb run as CGI script (not as legacy, i.e. ModPerl::Registry, mod_perl script) $ ab <opt> "http://localhost/cgi-bin/gitweb/gitweb.cgi/git.git/shortlog" I got the folowing results
| before | after ------------+-----------------|------------------ -n 10 | 1094.050 [ms] | 989.136 [ms] -n 10 -c 2 | 1147.965 [ms] | 1041.324 [ms]
which means around 10% improvement. Standard deviation is around 10 ms for no concurrency, and around 200 ms (more than third of difference) for concurrent connections. Shown here is time per request (mean, across all concurrent requests).
Show 18 quoted lines
> gitweb/gitweb.perl | 30 +++++++++++++++++++++++++++---
> 1 files changed, 27 insertions(+), 3 deletions(-)
>
> diff --git a/gitweb/gitweb.perl b/gitweb/gitweb.perl
> index ad9ae31..de4cc63 100755
> --- a/gitweb/gitweb.perl
> +++ b/gitweb/gitweb.perl
> @@ -1515,6 +1515,27 @@ sub format_subject_html {
> }
> }
>
> +# Rather than recomputing the url for an email multiple times, we cache it
> +# after the first hit. This gives a visible benefit in views where the avatar
> +# for the same email is used repeatedly (e.g. shortlog).
> +# The cache is shared by all avatar engines (currently gravatar only), which
> +# are free to use it as preferred. Since only one avatar engine is used for any
> +# given page, there's no risk for cache conflicts.
> +our %avatar_cache = ();Good comment.
Show 11 quoted lines
> +
> +# Compute the gravatar url for a given email, if it's not in the cache already.
> +# Gravatar stores only the part of the URL before the size, since that's the
> +# one computationally more expensive. This also allows reuse of the cache for
> +# different sizes (for this particular engine).
> +sub gravatar_url {
> + my $email = lc shift;
> + my $size = shift;
> + $avatar_cache{$email} ||=
> + "http://www.gravatar.com/avatar.php?gravatar_id=" .
> + Digest::MD5::md5_hex($email) . "&size=";The same comment as for previous patch: why not use modern API?
+ "http://www.gravatar.com/avatar/" . + Digest::MD5::md5_hex($email) . "?size=";
> + return $avatar_cache{$email} . $size;
> +}Nice.
Show 12 quoted lines
> +
> # Insert an avatar for the given $email at the given $size if the feature
> # is enabled.
> sub git_get_avatar {
> @@ -1524,15 +1545,18 @@ sub git_get_avatar {
> my $size = $avatar_size{$opts{'size'}} || $avatar_size{'default'};
> my $url = "";
> if ($git_avatar eq 'gravatar') {
> - $url = "http://www.gravatar.com/avatar.php?gravatar_id=" .
> - Digest::MD5::md5_hex(lc $email) . "&size=$size";
> + $url = gravatar_url($email, $size);
> }Great encapsulation.
Show 11 quoted lines
> # Currently only gravatars are supported, but other forms such as
> # picons can be added by putting an else up here and defining $url
> # as needed. If no variant puts something in $url, we assume avatars
> # are completely disabled/unavailable.
> if ($url) {
> - return $pre_white . "<img width=\"$size\" class=\"avatar\" src=\"$url\" />" . $post_white;
> + return $pre_white .
> + "<img width=\"$size\" " .
> + "class=\"avatar\" " .
> + "src=\"$url\" " .
> + "/>" . $post_white;This is independent change. It shouldn't be here; if you prefer such solution, you should squash it with previous patch. Please drop this chunk.
> } else {
> return "";
> }
> -- Thanks again for great work on this series!
-- Jakub Narebski Poland