Re: [PATCH] process_{tree,blob}: Remove useless xstrdup calls

From: Linus Torvalds <torvalds@linux-foundation.org>
Date: Apr 11, 2009, 21:43 UTC
Message-ID: <alpine.LFD.2.00.0904111441240.4583@localhost.localdomain>
In-Reply-To: <20090411205044.GA21673@atjola.homenet>

On Sat, 11 Apr 2009, Björn Steinbrink wrote:

Show 9 quoted lines

> > 
> > And I think I can see why. The new code actually does a _better_ job of 
> > the resulting list being in "recency" order, whereas the old code used to 
> > output the root trees all together. Now they're spread out according to 
> > how soon they are reached.
> 
> Hm, I don't think that was the case. When iterating over the commits,
> process_tree was called with commit->tree, and that added the root tree
> to the objects array as well as walking it to add all referenced objects.

Oh, you're right. We actually ended up walking the trees at that point, so recency should be the same.

Hmm. Where does the difference in ordering come from, then?

			Linus