Re: [PATCH] process_{tree,blob}: Remove useless xstrdup calls

From: Linus Torvalds <torvalds@linux-foundation.org>
Date: Apr 11, 2009, 18:19 UTC
Message-ID: <alpine.LFD.2.00.0904111115210.4583@localhost.localdomain>
In-Reply-To: <20090411140756.GA15288@atjola.homenet>

On Sat, 11 Apr 2009, Björn Steinbrink wrote:

Show 17 quoted lines

> On 2009.04.11 15:41:12 +0200, Björn Steinbrink wrote:
> > On 2009.04.10 18:15:26 -0700, Linus Torvalds wrote:
> > > It obviously goes on top of my previous patch.
> > 
> > Gives some nice results for the "rev-list --all --objects" test on the
> > gentoo repo says (with the old pack):
> >      | With my patch | With your patch on top
> > -----|---------------|-----------------------
> > VSZ  |       1667952 | 1319324
> > RSS  |       1388408 | 1126080
> 
> linux-2.6.git:
> 
>      | With my patch | With your patch on top
> -----|---------------|-----------------------
> VSZ  |        460376 | 407900
> RSS  |        292996 | 239760

Interesting. That's a 18+% reduction in RSS in both cases. Much bigger than I expected, or what I saw in my limited testing. Is this in 32-bit mode, where the pointers are cheaper, and thus the non-pointer data relatively more expensive and a bigger percentage of the total? We really wasted a _lot_ of memory on those names.

		Linus