[PATCH] process_{tree,blob}: Remove useless xstrdup calls
- From
Björn Steinbrink <b.steinbrink@gmx.de>
- Date
- Apr 8, 2009, 11:28 UTC
- Message-ID
- <20090408112854.GA8624@atjola.homenet>
- In-Reply-To
- <alpine.LFD.2.00.0904070903020.6741@xanadu.home>
The name of the processed object was duplicated for passing it to add_object(), but that already calls path_name, which allocates a new string anyway. So the memory allocated by the xstrdup calls just went nowhere, leaking memory.
Signed-off-by: Björn Steinbrink <B.Steinbrink@gmx.de> --- This reduces the RSS usage for a "rev-list --all --objects" by about 10% on the gentoo repo (fully packed) as well as linux-2.6.git:
gentoo: | old | new ----------------|------------------------------- RSS | 1537284 | 1388408 VSZ | 1816852 | 1667952 time elapsed | 1:49.62 | 1:48.99 min. page faults| 417178 | 379919
linux-2.6.git: | old | new ----------------|------------------------------- RSS | 324452 | 292996 VSZ | 491792 | 460376 time elapsed | 0:14.53 | 0:14.28 min. page faults| 89360 | 81613
list-objects.c | 2 -- reachable.c | 1 - 2 files changed, 0 insertions(+), 3 deletions(-)
diff --git a/list-objects.c b/list-objects.c index c8b8375..dd243c7 100644 --- a/list-objects.c +++ b/list-objects.c @@ -23,7 +23,6 @@ static void process_blob(struct rev_info *revs, if (obj->flags & (UNINTERESTING | SEEN)) return; obj->flags |= SEEN; - name = xstrdup(name); add_object(obj, p, path, name); } @@ -78,7 +77,6 @@ static void process_tree(struct rev_info *revs, if (parse_tree(tree) < 0) die("bad tree object %s", sha1_to_hex(obj->sha1)); obj->flags |= SEEN; - name = xstrdup(name); add_object(obj, p, path, name); me.up = path; me.elem = name; diff --git a/reachable.c b/reachable.c index 3b1c18f..b515fa2 100644 --- a/reachable.c +++ b/reachable.c @@ -48,7 +48,6 @@ static void process_tree(struct tree *tree, obj->flags |= SEEN; if (parse_tree(tree) < 0) die("bad tree object %s", sha1_to_hex(obj->sha1)); - name = xstrdup(name); add_object(obj, p, path, name); me.up = path; me.elem = name;
-- 1.6.2.2.446.gfbdc0.dirty