Re: [PATCH] process_{tree,blob}: Remove useless xstrdup calls
- From
Björn Steinbrink <b.steinbrink@gmx.de>
- Date
- Apr 11, 2009, 13:41 UTC
- Message-ID
- <20090411134112.GA1673@atjola.homenet>
- In-Reply-To
- <alpine.LFD.2.00.0904101806340.4583@localhost.localdomain>
On 2009.04.10 18:15:26 -0700, Linus Torvalds wrote:
> It obviously goes on top of my previous patch.
Gives some nice results for the "rev-list --all --objects" test on the gentoo repo says (with the old pack):
| With my patch | With your patch on top -----|---------------|----------------------- VSZ | 1667952 | 1319324 RSS | 1388408 | 1126080 time | 1:48.99 | 1:42.24
Testing a full repack, it feels slower during the "Compressing objects" part, but I don't have any hard numbers on that, and maybe I've just been more patient the last week, when I did the first repack on that repo. I can just tell that it took about 13 minutes for the "Compressing objects" part, and 18 minutes in total, on my Core 2 Quad 2.83GHz with 4G of RAM.
The new pack is slightly worse than the old one (window=250, --depth=250): Old: 759662467 New: 759720234
But that's seems totally negligible, and at least the performance of the (stupid) rev-list test is not affected by the different pack layout.
Björn