Re: [PATCH] process_{tree,blob}: Remove useless xstrdup calls

From: Linus Torvalds <torvalds@linux-foundation.org>
Date: Apr 11, 2009, 18:22 UTC
Message-ID: <alpine.LFD.2.00.0904111119520.4583@localhost.localdomain>
In-Reply-To: <alpine.LFD.2.00.0904111055480.4583@localhost.localdomain>

On Sat, 11 Apr 2009, Linus Torvalds wrote:

Show 11 quoted lines

> On Sat, 11 Apr 2009, Björn Steinbrink wrote:
> 
> > And again, the new pack is slightly worse than the old one
> >  (window=250, --depth=250).
> > Old: 240238406
> > New: 240280452
> > 
> > But again, it's negligible.
> 
> Well, it's sad that it's consistently a bit worse, even if we're talking 
> just small small fractions of a percent (looks like 0.02% bigger ;).

Oh, just wondering: that 0.02% is negligible, but did you use "-f" (or --no-reuse-delta if you're testing with 'git pack-objects') to see that it's actually re-computing the deltas?

The 0.02% difference might be just because of differences in pack layout. If you force all deltas to be recomputed, maybe the difference is much bigger?

		Linus