Re: [PATCH] don't use mmap() to hash files

From: Johannes Schindelin <johannes.schindelin@gmx.de>
Date: Feb 14, 2010, 01:53 UTC
Message-ID: <alpine.DEB.1.00.1002140249410.20986@pacific.mpi-cbg.de>
In-Reply-To: <20100214011812.GA2175@dpotapov.dyndns.org>

Hi,

On Sun, 14 Feb 2010, Dmitry Potapov wrote:

> +	if (strbuf_read(&sbuf, fd, 4096) >= 0)

How certain are you at this point that all of fd's contents fit into your memory?

And even if you could be certain, a hint is missing that strbuf_read(), its name notwithstanding, does not read NUL-terminated strings. Oh, and the size is just a hint for the initial size, and it reads until EOF. That has to be said in the commit message.

Ciao, Dscho

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.