Re: [PATCH] Teach "git add" and friends to be paranoid

From: Nicolas Pitre <nico@fluxnic.net>
Date: Feb 18, 2010, 19:58 UTC
Message-ID: <alpine.LFD.2.00.1002181456230.1946@xanadu.home>
In-Reply-To: <7vtytee7ff.fsf@alter.siamese.dyndns.org>

On Thu, 18 Feb 2010, Junio C Hamano wrote:

Show 8 quoted lines

> Thomas Rast <trast@student.ethz.ch> writes:
> 
> > This makes it sound as if the user is to blame, but IMHO we're just
> > not checking the input well enough.
> 
> Honesty is very good.  An alternative implementation that does not hurt
> performance as much as the "paranoia" would, and checks "the input well
> enough" would be very welcome.

Can't we rely on the mtime of the source file? Sample it before starting hashing it, then make sure it didn't change when done.

Nicolas

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.