Re: [PATCH] don't use mmap() to hash files
- From
Avery Pennarun <apenwarr@gmail.com>
- Date
- Feb 15, 2010, 19:19 UTC
- Message-ID
- <32541b131002151119o2f528ddv147d71d12d9d11fe@mail.gmail.com>
- In-Reply-To
- <alpine.LFD.2.00.1002150016110.1946@xanadu.home>
On Mon, Feb 15, 2010 at 12:48 AM, Nicolas Pitre <nico@fluxnic.net> wrote:
> Ideally you don't keep volatile objects into huge packs. That's why we > have .keep to flag those packs that are huge and pure so not to touch > them anymore.
Of course the problem here is that as soon as you import a single (possibly volatile) 2GB file, your pack becomes "huge." So these heuristics stop working very well and start to need some revision.
Thanks for the clarification on packing and repacking. I might be able to use this method to come up with a better repacking/pruning algorithm in bup, and from there to perhaps forward it on to git.
Have fun,
Avery