Re: [PATCH] don't use mmap() to hash files

From: Junio C Hamano <gitster@pobox.com>
Date: Feb 14, 2010, 01:37 UTC
Message-ID: <7vtytk61im.fsf@alter.siamese.dyndns.org>
In-Reply-To: <20100214011812.GA2175@dpotapov.dyndns.org>

Dmitry Potapov <dpotapov@gmail.com> writes:

Show 7 quoted lines

> If a mmapped file is changed by another program during git-add, it
> causes the repository corruption. Disabling mmap() in index_fd() does
> not have any negative impact on the overall speed of Git. In fact, it
> makes git hash-object to work slightly faster....
> ...
> I think more people should test this change to see its impact on
> performance. For me, it was positive. Here is my results:

I wasn't particularly impressed by the original problem description, but this is a very interesting result.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.