From: Johannes Schindelin <johannes.schindelin@gmx.de>
Date: Sun, 14 Feb 2010 01:53:58 GMT
Subject: Re: [PATCH] don't use mmap() to hash files
Message-ID: <alpine.DEB.1.00.1002140249410.20986@pacific.mpi-cbg.de>
In-Reply-To: <20100214011812.GA2175@dpotapov.dyndns.org>

Hi,

On Sun, 14 Feb 2010, Dmitry Potapov wrote:

> +	if (strbuf_read(&sbuf, fd, 4096) >= 0)

How certain are you at this point that all of fd's contents fit into your 
memory?

And even if you could be certain, a hint is missing that strbuf_read(), 
its name notwithstanding, does not read NUL-terminated strings. Oh, and 
the size is just a hint for the initial size, and it reads until EOF. That 
has to be said in the commit message.

Ciao,
Dscho