git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: janitoring

From
Johannes Schindelin <johannes.schindelin@gmx.de>
Date
Jul 22, 2009, 22:29 UTC
Message-ID
<alpine.DEB.1.00.0907230028230.3155@pacific.mpi-cbg.de>
In-Reply-To
<7vws60cr9m.fsf@alter.siamese.dyndns.org>
Hi,
On Wed, 22 Jul 2009, Junio C Hamano wrote:
Show 14 quoted lines
> Pierre Habouzit <madcoder@debian.org> writes:
> 
> > [PATCH 1/3] janitor: use NULL and not 0 for pointers.
> >
> >   I really dislike the use of 0 when NULL is meant. This patch probably
> >   fixes most of them. The biggest culprit is nedmalloc, but a few
> >   remnants exist in plain git code.
> 
> I am not enthused about "fixing" borrowed foreign code, unless we know
> that we are committed to support our fork.  My impression was that this
> ned stuff was borrowed by the MinGW folks with the understanding that we
> will slurp it with minimum modification and turn a blind eye to its
> sub-par coding styles, so that it can be more easily updated from the
> upstream?

Indeed. Maintaining msysGit is enough of a burden already (and I do not often get to do fun stuff anymore). So I really appreciate your concern here.

Ciao, Dscho

Previous: Junio C HamanoNext: Johannes Sixt
Message 13 of 14 in “janitoring”
  1. Pierre HabouzitJul 22, 2009
  2. 1/3 janitor: use NULL and not 0 for pointers.Pierre Habouzit, Jul 22, 2009
  3. 2/3 refactor: use bitsizeof() instead of 8 * sizeof()Pierre Habouzit, Jul 22, 2009
  4. 3/3 janitor: add DIV_ROUND_UP and use it.Pierre Habouzit, Jul 22, 2009
  5. Jeff KingJul 23, 2009
  6. Junio C HamanoJul 23, 2009
  7. Jeff KingJul 23, 2009
  8. Junio C HamanoJul 23, 2009
  9. Pierre HabouzitJul 23, 2009
  10. Junio C HamanoJul 22, 2009
  11. Pierre HabouzitJul 22, 2009
  12. Junio C HamanoJul 22, 2009
  13. Johannes SchindelinJul 22, 2009
  14. Johannes SixtJul 23, 2009

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.