Re: janitoring

From: Junio C Hamano <gitster@pobox.com>
Date: Jul 22, 2009, 22:19 UTC
Message-ID: <7v7hy0cqei.fsf@alter.siamese.dyndns.org>
In-Reply-To: <20090722220209.GE13823@artemis.corp>

Pierre Habouzit <madcoder@madism.org> writes:

Show 18 quoted lines

> On Wed, Jul 22, 2009 at 03:00:21PM -0700, Junio C Hamano wrote:
>> Pierre Habouzit <madcoder@debian.org> writes:
>> 
>> > [PATCH 1/3] janitor: use NULL and not 0 for pointers.
>> >
>> >   I really dislike the use of 0 when NULL is meant. This patch probably
>> >   fixes most of them. The biggest culprit is nedmalloc, but a few
>> >   remnants exist in plain git code.
>> 
>> I am not enthused about "fixing" borrowed foreign code, unless we know
>> that we are committed to support our fork.  My impression was that this
>> ned stuff was borrowed by the MinGW folks with the understanding that we
>> will slurp it with minimum modification and turn a blind eye to its
>> sub-par coding styles, so that it can be more easily updated from the
>> upstream?
>
> Okay, maybe the 2-3 hunks that don't apply to nedmalloc stuff can be
> saved though, do you want me to send an updated patch ?

No, I'll split out that part and queue the rest.

Thanks.