git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH 2/3] refactor: use bitsizeof() instead of 8 * sizeof()

From
Junio C Hamano <gitster@pobox.com>
Date
Jul 23, 2009, 05:09 UTC
Message-ID
<7v3a8o6l3v.fsf@alter.siamese.dyndns.org>
In-Reply-To
<20090723050711.GB9189@coredump.intra.peff.net>
Jeff King <peff@peff.net> writes:
Show 6 quoted lines
> On Wed, Jul 22, 2009 at 11:34:34PM +0200, Pierre Habouzit wrote:
>
>>  #define ARRAY_SIZE(x) (sizeof(x)/sizeof(x[0]))
>> +#define bitsizeof(x)  (CHAR_BIT * sizeof(x))
>
> Isn't our style to use all-caps for macros? I.e., BITSIZEOF?

Perhaps but I'd say similarity between sizeof() and bitsizeof() calls for consistency in the lowercase in this particular case.

Previous: Jeff KingNext: Jeff King
Message 6 of 14 in “janitoring”
  1. Pierre HabouzitJul 22, 2009
  2. 1/3 janitor: use NULL and not 0 for pointers.Pierre Habouzit, Jul 22, 2009
  3. 2/3 refactor: use bitsizeof() instead of 8 * sizeof()Pierre Habouzit, Jul 22, 2009
  4. 3/3 janitor: add DIV_ROUND_UP and use it.Pierre Habouzit, Jul 22, 2009
  5. Jeff KingJul 23, 2009
  6. Junio C HamanoJul 23, 2009
  7. Jeff KingJul 23, 2009
  8. Junio C HamanoJul 23, 2009
  9. Pierre HabouzitJul 23, 2009
  10. Junio C HamanoJul 22, 2009
  11. Pierre HabouzitJul 22, 2009
  12. Junio C HamanoJul 22, 2009
  13. Johannes SchindelinJul 22, 2009
  14. Johannes SixtJul 23, 2009

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.