git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: janitoring

From
Junio C Hamano <gitster@pobox.com>
Date
Jul 22, 2009, 22:00 UTC
Message-ID
<7vws60cr9m.fsf@alter.siamese.dyndns.org>
In-Reply-To
<1248298475-2990-1-git-send-email-madcoder@debian.org>
Pierre Habouzit <madcoder@debian.org> writes:
Show 5 quoted lines
> [PATCH 1/3] janitor: use NULL and not 0 for pointers.
>
>   I really dislike the use of 0 when NULL is meant. This patch probably
>   fixes most of them. The biggest culprit is nedmalloc, but a few
>   remnants exist in plain git code.

I am not enthused about "fixing" borrowed foreign code, unless we know that we are committed to support our fork. My impression was that this ned stuff was borrowed by the MinGW folks with the understanding that we will slurp it with minimum modification and turn a blind eye to its sub-par coding styles, so that it can be more easily updated from the upstream?

Previous: Pierre HabouzitNext: Pierre Habouzit
Message 10 of 14 in “janitoring”
  1. Pierre HabouzitJul 22, 2009
  2. 1/3 janitor: use NULL and not 0 for pointers.Pierre Habouzit, Jul 22, 2009
  3. 2/3 refactor: use bitsizeof() instead of 8 * sizeof()Pierre Habouzit, Jul 22, 2009
  4. 3/3 janitor: add DIV_ROUND_UP and use it.Pierre Habouzit, Jul 22, 2009
  5. Jeff KingJul 23, 2009
  6. Junio C HamanoJul 23, 2009
  7. Jeff KingJul 23, 2009
  8. Junio C HamanoJul 23, 2009
  9. Pierre HabouzitJul 23, 2009
  10. Junio C HamanoJul 22, 2009
  11. Pierre HabouzitJul 22, 2009
  12. Junio C HamanoJul 22, 2009
  13. Johannes SchindelinJul 22, 2009
  14. Johannes SixtJul 23, 2009

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.