git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: janitoring

From
PHPierre Habouzit <madcoder@madism.org>
Date
Jul 22, 2009, 22:02 UTC
Message-ID
<20090722220209.GE13823@artemis.corp>
In-Reply-To
<7vws60cr9m.fsf@alter.siamese.dyndns.org>
On Wed, Jul 22, 2009 at 03:00:21PM -0700, Junio C Hamano wrote:
Show 14 quoted lines
> Pierre Habouzit <madcoder@debian.org> writes:
> 
> > [PATCH 1/3] janitor: use NULL and not 0 for pointers.
> >
> >   I really dislike the use of 0 when NULL is meant. This patch probably
> >   fixes most of them. The biggest culprit is nedmalloc, but a few
> >   remnants exist in plain git code.
> 
> I am not enthused about "fixing" borrowed foreign code, unless we know
> that we are committed to support our fork.  My impression was that this
> ned stuff was borrowed by the MinGW folks with the understanding that we
> will slurp it with minimum modification and turn a blind eye to its
> sub-par coding styles, so that it can be more easily updated from the
> upstream?

Okay, maybe the 2-3 hunks that don't apply to nedmalloc stuff can be saved though, do you want me to send an updated patch ?

-- 
Intersec <http://www.intersec.com>
Pierre Habouzit <pierre.habouzit@intersec.com>
Tél : +33 (0)1 5570 3346
Mob : +33 (0)6 1636 8131
Fax : +33 (0)1 5570 3332
37 Rue Pierre Lhomme
92400 Courbevoie
Previous: Junio C HamanoNext: Junio C Hamano
Message 11 of 14 in “janitoring”
  1. Pierre HabouzitJul 22, 2009
  2. 1/3 janitor: use NULL and not 0 for pointers.Pierre Habouzit, Jul 22, 2009
  3. 2/3 refactor: use bitsizeof() instead of 8 * sizeof()Pierre Habouzit, Jul 22, 2009
  4. 3/3 janitor: add DIV_ROUND_UP and use it.Pierre Habouzit, Jul 22, 2009
  5. Jeff KingJul 23, 2009
  6. Junio C HamanoJul 23, 2009
  7. Jeff KingJul 23, 2009
  8. Junio C HamanoJul 23, 2009
  9. Pierre HabouzitJul 23, 2009
  10. Junio C HamanoJul 22, 2009
  11. Pierre HabouzitJul 22, 2009
  12. Junio C HamanoJul 22, 2009
  13. Johannes SchindelinJul 22, 2009
  14. Johannes SixtJul 23, 2009

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.