From: Johannes Schindelin Date: Wed, 22 Jul 2009 22:29:55 GMT Subject: Re: janitoring Message-ID: In-Reply-To: <7vws60cr9m.fsf@alter.siamese.dyndns.org> Hi, On Wed, 22 Jul 2009, Junio C Hamano wrote: > Pierre Habouzit writes: > > > [PATCH 1/3] janitor: use NULL and not 0 for pointers. > > > > I really dislike the use of 0 when NULL is meant. This patch probably > > fixes most of them. The biggest culprit is nedmalloc, but a few > > remnants exist in plain git code. > > I am not enthused about "fixing" borrowed foreign code, unless we know > that we are committed to support our fork. My impression was that this > ned stuff was borrowed by the MinGW folks with the understanding that we > will slurp it with minimum modification and turn a blind eye to its > sub-par coding styles, so that it can be more easily updated from the > upstream? Indeed. Maintaining msysGit is enough of a burden already (and I do not often get to do fun stuff anymore). So I really appreciate your concern here. Ciao, Dscho